For most photographers, Photoshop is one of, if not the primary tool used to make adjustments to digital photos. It's their darkroom, allowing creativity and correction for mistakes made in, or uncontrollable situations while shooting. Additionally, it can be used to black and white, sepia and other color conversions, selective color, blemish removal and removing red eye. With every release of Photoshop, more tools are available, making the toolbox grow and the editing abilities near endless. That's not to say every filter and every option should always be used, there are some things that are just a crime in Photoshop.
Saving over your originals is one of the things I've always been conscious of not doing, but in talking with other photographers, they apparently do it on a regular basis. Perhaps it comes from a bad habit formed from writing long papers in school and always hitting cmd (ctrl for you Windows folks) + S while writing that translated over to Photoshop for saving while in progress. No matter what, you should never save over your original files!
Upsizing your files is never a good idea, no matter what! Upsizing is a term used when you resize an photo (Image > Image size) to a dimension larger then it was originally shot in, usually for printing. Some printers set a minimum suggested size for larger prints, one that exceeds that of most digital cameras. What I mean is, a Printer might be looking for a preferred digital photo that is 6000×9000 @ 300 DPI for what it would consider an amazing print. By the math, that's a 54MP camera would be needed! The reality is, most DSLRs on the market 10mp and higher are more than capable of producing stunning 20×30″ prints provided the exposure was done well and the ISO isnt' too high. Don't ever upsize your photos, all you'll get is a monstrous file that has no more real data in it, but looks more pixelated.
HDR‘ing photos to death. High Dynamic Range is a wonderful thing, however it's often over-done and leaves less than pleasing results. If you totally lose the highlight and / or shadow detail, have a glowing effect around any part of the image or it starts to look more like a painting, you are probably abusing the HDR functionality in Photoshop. There is a time and place for HDR, but the over-kill that is showing up on the Internet is not the best use of it.
Photo by Burst
Using the erase tool instead of masking is one of the biggest mistakes photographers make while editing. Most photographers have learned to manipulate Photoshop, originally a graphic design tool, and learned on their own how it works. The erase tool makes sense, it simply erases. Utilizing masks takes a bit of understanding but is far more flexible and does far less damage.
Not utilizing smart filters leaves your original file in tact, and editable. Utilizing them in your work-flow is simple and easy to do. Select the layer you want to apply to and go to Filters > Smart Filters and it will convert the layer into a smart object.
Shortcuts in Photoshop are huge time savers and learning them, even the most basic ones, will drastically speed up your work-flow. Most all menu systems in Photoshop tell you the shortcut when you select it with the cursor, but a complete list of all versions of Photoshop (excluding the newly released CS5) can be found here.
Grayscale is not the best B&W conversion tool available in Photoshop. Many new users of Photoshop convert color photos to black and white via the Image > Mode > Grayscale option. This result is muddy and has no real tonal quality to it. There are far better ways, actions and plugins to help convert your color photos to black and white that will create stunning photos, not muddy, dull and boring black and whites.
Photoshop is an intense program that I honestly don't think anyone ever masters. That's not to say you can't use it to the best of your ability, learn a few things and avoid damaging your images or outputting poor quality work. For me, Photoshop is an ongoing learning process and I'm guilty of making most of these mistakes at least once over the last 12 years or so. Learn, progress, improve and move on.